prometheus-community
[prometheus-node-exporter] Update labels to match best practices
What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
- fixes #
Special notes for your reviewer:
This PR updates the node exporter labels to match the best practice described here: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
Checklist
- [x] DCO signed
- [x] Chart Version bumped
- [x] Title of the PR starts with chart name (e.g.
[prometheus-couchdb-exporter])
@monotek do we have an example I could use as I think it's not the first time this happened in this repo ? :D
I found an example for the stackdriver exporter that exactly matches what I needed :) I'm not sure the linting error make sense though
@zanhsieh why are you requesting a review? the readme was not changed and is still wrong.
@monotek I will try the upgrade but the readme was changed https://github.com/prometheus-community/helm-charts/pull/2212/commits/af533d6fd5765b143dcbd70dc50667dfdfe80b23
@monotek looks like I can't see your review in this one anymore. Anything that it still open from your side here?
Yes, my posted suggestion. Not the deployment but the deamonset has to be deleted.
I signed off your commit but this should be fine now, sorry about all those missed parts :(