ansible icon indicating copy to clipboard operation
ansible copied to clipboard

feat: include influxdb exporter role

Open dobbi84 opened this issue 1 year ago • 3 comments

Include the Influxdb exporter role.

We rely on such exporter because we have applications that push metrics directly to Influxdb at runtime, using this exporter allows us to have those metrics in Prometheus. We have created this role getting inspired by the current Node Exporter role already present in this collection, thanks.

dobbi84 avatar Aug 06 '24 14:08 dobbi84

Can you please rebase this against main to pick up the changes in #395

SuperQ avatar Sep 28 '24 12:09 SuperQ

Can you please rebase this against main to pick up the changes in #395

should be updated now

dobbi84 avatar Oct 03 '24 11:10 dobbi84

Sorry, this needs a rebase again now that we have a _common role pattern.

SuperQ avatar Oct 17 '24 13:10 SuperQ

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main: https://prometheus-community.github.io/ansible/branch/main

github-actions[bot] avatar Oct 18 '24 15:10 github-actions[bot]

@gardar it is not allowed to create homes in / https://github.com/prometheus-community/ansible/blob/4670e4ad23a081c75fe101ca68fc1f132d9b390e/roles/_common/tasks/install.yml#L40. If a role goes for the default, it fails.

I do not understand why would be needed to set the home to the config dir if anyway create_home is set to false: https://github.com/prometheus-community/ansible/blob/4670e4ad23a081c75fe101ca68fc1f132d9b390e/roles/_common/tasks/install.yml#L41

dobbi84 avatar Oct 18 '24 16:10 dobbi84

@gardar it is not allowed to create homes in /

https://github.com/prometheus-community/ansible/blob/4670e4ad23a081c75fe101ca68fc1f132d9b390e/roles/_common/tasks/install.yml#L40 . If a role goes for the default, it fails.

I do not understand why would be needed to set the home to the config dir if anyway create_home is set to false:

https://github.com/prometheus-community/ansible/blob/4670e4ad23a081c75fe101ca68fc1f132d9b390e/roles/_common/tasks/install.yml#L41

Yeah that doesn't sound right, shouldn't it be using the config dir? "{{ influxdb_exporter_config_dir }}"

gardar avatar Oct 18 '24 16:10 gardar

@SuperQ something is wrong with Molecule Ubuntu container

dobbi84 avatar Oct 19 '24 07:10 dobbi84

The CI issues should be fixed now #440

gardar avatar Oct 23 '24 17:10 gardar