prometheus-community
fix: scrape config files path
Unfortunately simply rebasing the original PR I missed that the paths in the actual role are wrong. I have now updated them ~and took the chance to also re-use the variable's value for the actual configuration not just the glob for copying~.
//edit: Cannot reuse variable since it would lead to /etc/prometheus/prometheus/scrapes/....
@gardar I would also add "notify"-Statements to all the file uploads to trigger a reload of Prometheus. May I add this in this PR?
@gardar Are these simple tests what you were looking for?
And I’m unsure if my approach for the "default" target is correct.
I rebased the branch on the latest master but unfortunately now all CI jobs for 2.9 failed. It appears to me that this may be due to reasons unrelated to the branch but I do not see a way to retry the jobs except by maybe pushing a new commit.
Could anyone just re-trigger the CI jobs, please?
I finally figured out that I couldn’t see CI job logs due to uMatrix not allowing XHR to "core.windows".
Anyway, the issue is entirely unrelated to this branch:
WARNING: Failed to pull docker image "quay.io/ansible/default-test-container:1.10.1".
Unfortunately the situation hasn't changed with the latest commits: https://github.com/prometheus-community/ansible/actions/runs/9756163117/job/26925952278?pr=377
@SuperQ Is there anything I can do to make the review easier for you?
Docs Build 📝
Thank you for contribution!✨
This PR has been merged and the docs are now incorporated into main:
https://prometheus-community.github.io/ansible/branch/main
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@SuperQ I did rename it, do you have any other suggestions?
Not too familiar with the Github UI, do I have to mark somehow that the requested change was performed?
Do you mind rebasing this again? I just did some significant refactoring of the roles in #425
While I hopefully solved these merge conflicts one last time I’m not comfortable to sink any more time into this PR. It has dragged on for more than four months now despite my best efforts to comply with requested changes and feedback in a timely manner due to reasons mostly outside of my control.
Thank you for your ongoing work on this project!
Do you mind rebasing this again? I just did some significant refactoring of the roles in #425
While I hopefully solved these merge conflicts one last time I’m not comfortable to sink any more time into this PR. It has dragged on for more than four months now despite my best efforts to comply with requested changes and feedback in a timely manner due to reasons mostly outside of my control.
Thank you for your ongoing work on this project!
LGTM! Thanks for the patience, you caught us at a bad time working through some technical debt 😅