ansible icon indicating copy to clipboard operation
ansible copied to clipboard

feat: Add prometheus_scrape_config feature

Open romanbilenko174 opened this issue 2 years ago • 5 comments

Added prometheus_scrape_config_files support as mentioned in https://github.com/prometheus-community/ansible/issues/145

romanbilenko174 avatar Oct 21 '23 17:10 romanbilenko174

Docs Build 📝

This PR is closed and any previously published docsite has been unpublished.

github-actions[bot] avatar Oct 21 '23 17:10 github-actions[bot]

Can you please fix the DCO?

gardar avatar Dec 14 '23 14:12 gardar

Hi, I am currently being blocked by #145 and would like to have this fixed.

I read the PR and I think there's nothing wrong with it technically. Because the PR is more than 3 months old, I am volunteering to take over this PR and drive it to finsh. IIUC the only missing piece is the missing sign-off, but (as I am not the author), I can't really provide that.

Is there a way forward? Or do I have to write my own version and submit that?

Lycowolf avatar Feb 12 '24 12:02 Lycowolf

Is there a way forward? Or do I have to write my own version and submit that?

Yes that would be the correct way for you to "take over".

@romanbilenko174 ping

Can you please fix the DCO?

gardar avatar Feb 12 '24 15:02 gardar

My version of this is https://github.com/prometheus-community/ansible/pull/292

Lycowolf avatar Feb 15 '24 15:02 Lycowolf

superseded by #368

gardar avatar May 29 '24 12:05 gardar