João Barbosa
João Barbosa
IMO this improves text contrast. However, other improvements could be made as well, some suggestions: - consistent error message near the invalid fields, for instance, the error message for invalid...
What approach are you considering?
@luke-jr feel free to try the commit 0ac4f7535a90bacb0e5ffe8f110505aa44075ad6 ([branch](https://github.com/promag/gui/tree/pr/506)) which avoids manual text wrap by using `Qt::TextWrapAnywhere` flag. Another thing I noticed is that the default minimum font size in...
> Isn't this impossible? No because it doesn't wrap. > I find the unnecessary QRect usage hard to follow. And I think it's unnecessary to calculate lines and manually wrap...
Concept ACK, gave it a try and I prefer this over #536. I will review it shortly. @meshcollider maybe we could throttle validation to make "brute force" tedious? - if...
Now I can't pick a different chain from the command line, for instance `src/qt/bitcoin-qt -regtest` gives `Error: Invalid combination of -regtest, -signet, -testnet and -chain. Can use at most one.`.
Concept ACK.
You think it should be reverted or that code should change to `g_scan_progress.load()`?
Concept ACK. @brunoerg I think it's fine as it. Should squash if the 1st commit requires the 2nd to pass CI.
@ryanofsky > The first commit "qt: Ditch wallet model juggling" ([f3e7047](https://github.com/bitcoin-core/gui/commit/f3e70479257770bc9f61de694db8704140139548)) is more confusing, because it seems like the new code is doing the same thing as the old code,...