James Mills

Results 704 comments of James Mills

@spaceone I think your solution is correct. Can you submit a PR with an associated test?

File a separate issue :) James Mills / prologic

Hmm; I'm not quite sure what you mean? What ideas do you have in mind? Do you mean a decorator to make writing custom decoraotrs that create event handlers a...

Ahh I see; so what are you ideas then? Turn `@handler` into a class that can be subclasses? How else can decorators be extended in this way?

If I'm not mistaken I _think_ you can do something like this: ``` def mydecorator(*args, **kwargS): @handler(...) def wrapper(f): return f(...) return wrapper ``` I think :)

e.g: [`circuits.web.controller.expose`](https://github.com/circuits/circuits/blob/master/circuits/web/controllers.py#L18)

Yeah I agree; this is less to do with function parameter inspection and more to do with: Do we need to send the `event` object? I'm _not_ sure how to...

Got any ideas around this? I haven't really looked much further into this (yet).

This breaks *all* of the assumptions around streaming and handling generated responses via `yield` and returning `Iterator` respones in circuits.web :/

@spaceone I'd be interested to see if your circuits.http breaks on top of this PR? Can you test it out?