github-nvim-theme icon indicating copy to clipboard operation
github-nvim-theme copied to clipboard

Is `hide_end_of_buffer` a good name?

Open tmillr opened this issue 1 year ago • 1 comments

Discussed in https://github.com/projekt0n/github-nvim-theme/discussions/206

Originally posted by bryanboateng September 13, 2022 Hi,

I set up the theme and was wondering why I could not see certain listchars (eol, precedes, extends). After searching for a long time I found hide_end_of_buffer. I find the name and description a bit unintuitive because the setting also controls the afformentioned listchars. Would it make sense to improve the naming and/or the description?

tmillr avatar Jul 12 '24 12:07 tmillr

Actually, I'm not sure if this group is used for anything else? So we might be good.

							*hl-EndOfBuffer*
EndOfBuffer	Filler lines (~) after the end of the buffer.
		By default, this is highlighted like |hl-NonText|.

From :h 'lcs':

	|hl-NonText| highlighting will be used for "eol", "extends" and
	"precedes". |hl-Whitespace| for "nbsp", "space", "tab", "multispace",
	"lead" and "trail".

tmillr avatar Jul 12 '24 12:07 tmillr