github-nvim-theme icon indicating copy to clipboard operation
github-nvim-theme copied to clipboard

github_dark_high_contrast colorscheme is not using options.styles config

Open aLucaz opened this issue 2 years ago • 6 comments

normal dark:

image

high contrast:

image

my config:

          styles = {                   -- Style to be applied to different syntax groups
            comments = 'italic',     -- Value is any valid attr-list value `:help attr-list`
            functions = 'NONE',
            keywords = 'italic',
            variables = 'NONE',
            conditionals = 'NONE',
            constants = 'NONE',
            numbers = 'NONE',
            operators = 'NONE',
            strings = 'NONE',
            types = 'NONE',
          },

also some keywords are not being considered like: function, import, from

aLucaz avatar Nov 17 '23 03:11 aLucaz

Same problem with the github_light theme.

gennadigennadigennadi avatar Nov 28 '23 21:11 gennadigennadigennadi

I observe the issue with github_dark_dimmed, but surprisingly NOT with github_light or github_dark_high_contrast.

av223119 avatar Dec 26 '23 22:12 av223119

Same problem with "github_dark_default"

rubensrbr avatar Jan 10 '24 01:01 rubensrbr

Ok for everyone that are having the same issue. I've spent some quality time to get my comments italic. For Lazy here is how the code looks like (options keyword is crucial here):

{
  "projekt0n/github-nvim-theme",
  lazy = false,
  priority = 1000,
  config = function()
    require("github-theme").setup({
      options = {
        styles = {
          comments = "italic",
        },
      },
    })
  end,
}

After that open new nvim instance and invoke in the cmd mode :GithubThemeCompile and after that it should work properly. Hope this helps someone.

Also this should be put, with exclamation mark, into the the README file, cause like we see a lot people are having problem with it.

mabugaj avatar Jan 15 '24 01:01 mabugaj

The compiler issue is mostly fixed at this point. Is anyone still experiencing this issue (after updating)?

tmillr avatar Jul 12 '24 03:07 tmillr