Badget icon indicating copy to clipboard operation
Badget copied to clipboard

Feature: White blank space issue when resizing internal UI component (on right side)

Open veerbal1 opened this issue 1 year ago • 10 comments

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'dashboard/transactions' & 'dashboard/accounts'
  2. Decrease right section width as minimum as possible - using resizable button
  3. Now try to scroll horizontally.
  4. See window get white blank space on right side and causing scrolling on x-axis

Expected behavior It should not scroll when we decrease width using resize button our internal UI components

Screenshots Screenshot 2024-01-22 at 3 11 21 PM

Desktop (please complete the following information):

  • OS: MacOS Intel Chip (Viewport 1440x900)
  • Browser: Arc

veerbal1 avatar Jan 22 '24 09:01 veerbal1

Ahh, yeah thats a problem! We need to look into it. Thanks for the headsup ✨

Codehagen avatar Jan 22 '24 14:01 Codehagen

Hey, I will be happy to work on this. Can you please assign this to me. @veerbal1 will you be working on this ?

codingsagar avatar Jan 22 '24 16:01 codingsagar

So im assigng it to you both. If there is something please contact me :)

Codehagen avatar Jan 23 '24 09:01 Codehagen

Sorry I accidentally unassigned this task to me. Please reassign it, I am starting to work on this. Thanks !

codingsagar avatar Jan 23 '24 09:01 codingsagar

@meglerhagen Please check the PR and the code changes. It was working good on my side. Kindly test on your side if possible.

veerbal1 avatar Jan 23 '24 10:01 veerbal1

Hello @codingsagar - Could you check the PR to see if the issue was solved at your end? Could not replicate the error.

Codehagen avatar Jan 23 '24 12:01 Codehagen

Sure, I'll check the PR. Will get back to you soon.

codingsagar avatar Jan 23 '24 17:01 codingsagar

Nice, tell me when you have checked 👍

Codehagen avatar Jan 23 '24 19:01 Codehagen

Hey, I tried a lot to replicate the error on my machine too but couldn't replicate. Tried with the same display size (1440x900) in the dev tools which was given in the issue itself and even tried to change machines resolution. Everything is working fine and responsive as much as I checked. Maybe this has to do something with the Arc Browser because of it there might be some issue.

codingsagar avatar Jan 23 '24 19:01 codingsagar

I also think the Arc browser is the problem @codingsagar. Can you try with another browser @veerbal1 ?

Codehagen avatar Jan 23 '24 20:01 Codehagen

I tested the live link https://projectx-eight-gilt.vercel.app/dashboard/transactions on Chrome, Mac Safari, Firefox and Arc browser. The scrolling issue exists in all browsers except Firefox.

Chrome -

https://github.com/meglerhagen/projectx/assets/55359171/26f86816-80be-4c1d-8e24-cf9bfdc66a4a

Mac Safari -

https://github.com/meglerhagen/projectx/assets/55359171/86cbc98b-1dce-4be4-b4da-7ca29aa2c76a

Arc -

https://github.com/meglerhagen/projectx/assets/55359171/efb73b51-946b-404a-8e26-27d4043ec426

Firefox was OK

After fixing in this PR https://github.com/meglerhagen/projectx/pull/73

https://github.com/meglerhagen/projectx/assets/55359171/b9d685a5-7989-4626-bd0e-5851cf3f2527

Screen dimensions - Screenshot 2024-01-24 at 12 18 54 PM

veerbal1 avatar Jan 24 '24 06:01 veerbal1

Hey @meglerhagen I again tried to replicate the error on Microsoft edge and I could now replicate the error. Previously I was using firefox in which its working fine. I checked the PR and after testing on my machine too its working fine. I think we can merge the PR.

codingsagar avatar Jan 24 '24 07:01 codingsagar

Thank you, merging now then @veerbal1 @codingsagar ✨

Codehagen avatar Jan 24 '24 13:01 Codehagen