Badget icon indicating copy to clipboard operation
Badget copied to clipboard

Published 20 hours ago • verified publisher icon projectx-codehagen

Feature/csv import

Open shouryan01 opened this issue 1 year ago • 5 comments

Description

Adds UI for uploading .csv files

What type of PR is this? (check all applicable)

  • [x ] 💡 Feature
  • [ ] 🐛 Bug Fix
  • [ ] 📝 Documentation Update
  • [ ] 🎨 Style
  • [ ] 🧑‍💻 Code Refactor
  • [ ] 🔥 Performance Improvements
  • [ ] ✅ Test
  • [ ] 🤖 Build
  • [ ] 🔁 CI
  • [ ] 📦 Chore (Release)
  • [ ] ⏩ Revert

Related Tickets & Documents

continues work on #196

Mobile & Desktop Screenshots/Recordings

image

Steps to QA

Added to documentation?

  • [ ] 📜 README.md
  • [ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

shouryan01 avatar Apr 13 '24 22:04 shouryan01

@shouryan01 is attempting to deploy a commit to the Salgsmaskin Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 13 '24 22:04 vercel[bot]

Writing parsing functions was time consuming

Luckily, I found a library which did what I initially had in mind for making the users do the data classification for us. Now you can upload a .csv file, it will try to map the columns for "Date", "Description" and "Amount". If there is not a column match, the user can manually match. The processed rows are displayed in the console.

image image

shouryan01 avatar Apr 14 '24 22:04 shouryan01

This looks very promising! Think this is the way to go, and we would also not need each person to added their bank. This will be a lot more dynamic ✨

Codehagen avatar Apr 15 '24 06:04 Codehagen

Yeah @meglerhagen that was the idea!

Now I had a question about mobile users: having that interface on a mobile sized screen is not a great experience; we'd need to build something from scratch for that use case.

But I was thinking: we could just disable manual file uploads from mobile sized screens? I checked with Bank of America and Chase, and both their mobile apps don't have a way to export transactions like their desktop counterparts do.

Therefore:

  1. It would take a few days to build the mobile UI, time better spent on other areas
  2. My hypothesis is that not many users would even use mobile phones for file manipulations because iOS file manager is clunky at best
  3. There doesn't seem a way to export transactions easily from apps anyway

What do you think? If they want manual uploads we can just direct them to the website

shouryan01 avatar Apr 16 '24 15:04 shouryan01

I agree with your approach. Lets disable it for mobile for now, even though we don't disable it its no problem. Minior fixes can the community also help with, while you do some heavy lifting 🏋️

Codehagen avatar Apr 16 '24 15:04 Codehagen