wallace-cli icon indicating copy to clipboard operation
wallace-cli copied to clipboard

Remove built-in css-fetching

Open bartveneman opened this issue 3 years ago • 5 comments

The headless CSS fetching mechanism requires a whole lot of dependencies and install time. I think it should be separated so that it would would be two different steps, using get-css or someone just piping a local file into wallace-cli:

get-css https://www.projectwallace.com > wallace

bartveneman avatar Jun 16 '21 10:06 bartveneman

Yes please.

Not to mention that puppeteer is a nightmare dependency to keep functional with all architectures, platforms, etc.

drewlustro avatar May 17 '22 22:05 drewlustro

Need help with this one?

I'm adopting wallace-cli at my org as an experiment. I'd be willing to give this issue a shot, provided wallace works out for us.

drewlustro avatar May 18 '22 23:05 drewlustro

Should be pretty straightforward, so feel free to pick up, but maybe I'll have some time this weekend to have a look.

bartveneman avatar May 19 '22 07:05 bartveneman

@drewlustro I have a WIP branch that's very lightweight and fast, without Puppeteer that you could try out using npx https://github.com/projectwallace/wallace-cli\#v3 path/to/style.css

bartveneman avatar May 25 '22 10:05 bartveneman

@bartveneman – Thanks mate.

I'm headed to Detroit for a music festival tonight, but will take a look next Thursday.

drewlustro avatar May 27 '22 02:05 drewlustro

@drewlustro I have a WIP branch that's very lightweight and fast, without Puppeteer that you could try out using npx https://github.com/projectwallace/wallace-cli\#v3 path/to/style.css

Does this work for anyone else? I just tried running and nothing happens: Screenshot 2023-09-06 at 1 17 29 PM

mryechkin avatar Sep 06 '23 17:09 mryechkin

I had to push some untested local changes because I got a new computer a while back, so its very well possible this branch is currently broken. I completely forgot about it.

Did you hit enter when it asked you to proceed though?

bartveneman avatar Sep 07 '23 09:09 bartveneman

Did you hit enter when it asked you to proceed though?

Yes, nothing happened - just returned me to the terminal.

I was able to build the v3 branch locally and use it that way, and it worked great - but obviously that's a temporary solution. Hopefully that PR can get merged at some point.

mryechkin avatar Sep 07 '23 13:09 mryechkin