react-diagrams icon indicating copy to clipboard operation
react-diagrams copied to clipboard

Remove hardcode for PointModel in DefaultLinkWidget.tsx

Open ToTheHit opened this issue 2 years ago • 2 comments

Checklist

  • [x] The code has been run through pretty yarn run pretty
  • [x] The tests pass on CircleCI
  • [x] You have referenced the issue(s) or other PR(s) this fixes/relates-to
  • [x] The PR Template has been filled out (see below)
  • [x] Had a beer/coffee because you are awesome

What?

Remove hardcode for PointModel in DefaultLinkWidget.tsx (☞゚ヮ゚)☞ https://github.com/projectstorm/react-diagrams/issues/938

Why?

  1. Hardcode is bad
  2. In current version of DefaultLinkWidget users can't use custom Points

How?

Simply using the already existing LinkModel method ༼ つ ◕_◕ ༽つ

Feel good image:

image

ToTheHit avatar May 04 '22 14:05 ToTheHit

click noice

dylanvorster avatar May 04 '22 15:05 dylanvorster

ill try get this merged soon after some testing on my side as well

dylanvorster avatar May 04 '22 15:05 dylanvorster