react-diagrams icon indicating copy to clipboard operation
react-diagrams copied to clipboard

React 18 support

Open robbinjanssen opened this issue 2 years ago • 5 comments

Will you support react 18, and do you have any idea what changes need to be made to support this? 👍 Happy to help if I got some pointers on what to do.

robbinjanssen avatar Apr 19 '22 09:04 robbinjanssen

I would like to migrate my project to React 18 but this is currently the only dependency that is holding me back. Some other dependencies that I am using now I cannot update because they have moved to React 18.

CodeMaven avatar Apr 28 '22 10:04 CodeMaven

I want this also !

maxtsh avatar May 25 '22 21:05 maxtsh

👍

akichim21 avatar Jun 08 '22 06:06 akichim21

Release notes for 6.7.4 indicate that react 18 should be supported. However I still get: npm ERR! Could not resolve dependency: npm ERR! peer react@"16.* || 17.*" from @projectstorm/[email protected] npm ERR! node_modules/@projectstorm/react-canvas-core npm ERR! @projectstorm/react-canvas-core@"^6.7.4" from the root project

CodeMaven avatar Jun 23 '22 11:06 CodeMaven

I've opened the PR to resolve peer deep, but right now you can override deps dependency. For example if you use npm add this to package.json with your react version:

  "overrides": {
    "@projectstorm/react-canvas-core": {
      "react": "$react" // or version here
    }
  }

vadimshvetsov avatar Jul 07 '22 09:07 vadimshvetsov

after we upgraded @types/react to 18, we also had to override this ProjectStorm type:

/ @ts-ignore
// eslint-disable-next-line implicit-dependencies/no-implicit
import { TransformLayerWidgetProps } from '@projectstorm/react-canvas-core'

// fixes an issue where children prop is removed from React.Component in React v18
// Remove when the React 18 release is official and tested: https://github.com/projectstorm/react-diagrams/releases/tag/v6.7.4
declare module '@projectstorm/react-canvas-core' {
  class TransformLayerWidget extends React.Component<
    PropsWithChildren<TransformLayerWidgetProps>
  > {}
}

scottdickerson avatar Oct 05 '22 13:10 scottdickerson