nessie icon indicating copy to clipboard operation
nessie copied to clipboard

GC-base module should not add dropped table's contents to live-content-references.

Open ajantha-bhat opened this issue 2 years ago • 3 comments

In IdentifyLiveContents, we are adding the "dropped table" files to live contents when a table's dropped time is newer than cutoff time /cutoff of commit. Which leads to not cleaning up of dropped table's files. Which is not same as "dropped reference" behaviour.

It may cause confusion to the users. Better not add dropped table's contents to the live-content-references.

ajantha-bhat avatar Sep 19 '22 06:09 ajantha-bhat

TBH, I do not understand what you mean with "dropped table" here. The code you referenced is about a Put operation, right?

snazy avatar Sep 19 '22 09:09 snazy

TBH, I do not understand what you mean with "dropped table" here. The code you referenced is about a Put operation, right?

As we are filtering out only the PUT operation, if the table(key) is dropped (DELETE operation), we are ignoring that commit and still adding its contents into the live content reference?

ajantha-bhat avatar Sep 19 '22 09:09 ajantha-bhat

Yes, the behavior is intentional. Dealing w/ completely unreferenced tables is a different topic. You've seen the chapter Potential future enhancements in #5209

snazy avatar Sep 19 '22 16:09 snazy