nessie icon indicating copy to clipboard operation
nessie copied to clipboard

WIP: refactor REST API

Open dimas-b opened this issue 2 years ago • 1 comments

dimas-b avatar Aug 25 '22 20:08 dimas-b

Codecov Report

Base: 80.50% // Head: 79.08% // Decreases project coverage by -1.41% :warning:

Coverage data is based on head (8d27488) compared to base (8d3a5e2). Patch coverage: 42.47% of modified lines in pull request are covered.

:exclamation: Current head 8d27488 differs from pull request most recent head cdeb6dd. Consider uploading reports for the commit cdeb6dd to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5004      +/-   ##
============================================
- Coverage     80.50%   79.08%   -1.42%     
- Complexity     3508     3603      +95     
============================================
  Files           485      522      +37     
  Lines         15483    16086     +603     
  Branches       1555     1585      +30     
============================================
+ Hits          12464    12722     +258     
- Misses         2416     2755     +339     
- Partials        603      609       +6     
Flag Coverage Δ
java 78.49% <42.47%> (-1.58%) :arrow_down:
javascript 82.91% <ø> (ø)
python 83.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rg/projectnessie/client/http/NessieHttpClient.java 82.35% <ø> (ø)
.../client/http/v2api/BaseHttpOnReferenceRequest.java 0.00% <0.00%> (ø)
...ojectnessie/client/http/v2api/BaseHttpRequest.java 0.00% <0.00%> (ø)
...jectnessie/client/http/v2api/HttpAssignBranch.java 0.00% <0.00%> (ø)
...projectnessie/client/http/v2api/HttpAssignTag.java 0.00% <0.00%> (ø)
...jectnessie/client/http/v2api/HttpDeleteBranch.java 0.00% <0.00%> (ø)
...projectnessie/client/http/v2api/HttpDeleteTag.java 0.00% <0.00%> (ø)
...g/projectnessie/client/http/v2api/HttpGetDiff.java 0.00% <0.00%> (ø)
...ctnessie/client/http/v2api/HttpMergeReference.java 0.00% <0.00%> (ø)
...essie/client/http/v2api/HttpTransplantCommits.java 0.00% <0.00%> (ø)
... and 39 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 25 '22 22:08 codecov[bot]

rebased

dimas-b avatar Nov 02 '22 14:11 dimas-b

I've squashed some of the review-based changes into the main (first) commit because the affected code got many changes from related PRs and the interplay of changes was becoming awkward. No functional changes though.

Will do another rebase after #5419 and #5435 are merged.

dimas-b avatar Nov 07 '22 16:11 dimas-b

rebased... addressing remaining comments :hourglass:

dimas-b avatar Nov 22 '22 15:11 dimas-b

Squashed. Rebased.

Changed v2 OpenAPI tag to v2-beta but went back to the simple /v2 URL paths.

Combined v1 and v2 in the same OpenAPI yaml. This also removes the mess in the Quarkus Swagger page.

dimas-b avatar Nov 30 '22 18:11 dimas-b

Thanks for the reviews @snazy and @XN137 !

I'll address remaining comments in follow-up PRs.

dimas-b avatar Dec 01 '22 14:12 dimas-b