nessie icon indicating copy to clipboard operation
nessie copied to clipboard

WIP add PR workflow for Nessie/Iceberg integration testing

Open snazy opened this issue 2 years ago • 1 comments

NOTE: This PR, actually the integrations-testing stuff it uses, is very much work-in-progress

It relies on the state in https://github.com/snazy/nessie-integration-tests/ - and that piece is changing rapidly. It is at least the foundation of Nessie-Query-Engine-Integration-Tests - i.e. to allow testing various query engines using Nessie against various environments.

See #4737

To merge this PR:

  • all above bullet-points "checked"
  • [ ] the nessie-integration-tests repo needs to be in projectnessie
  • [ ] need a branch in projectnessie/nessie that contains the patches for Nessie to make it work against "latest Iceberg"
  • [ ] need a (temporary) fork of apache/iceberg - but only apply the Iceberg PRs https://github.com/apache/iceberg/pull/5051 and https://github.com/apache/iceberg/pull/5193 - however, maybe we need a "permanent patch branch"

snazy avatar Jul 12 '22 16:07 snazy

Codecov Report

Merging #4686 (b5f63c9) into main (eb452df) will decrease coverage by 0.16%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4686      +/-   ##
==========================================
- Coverage   82.86%   82.70%   -0.17%     
==========================================
  Files          31       49      +18     
  Lines        1436     1758     +322     
  Branches      249      338      +89     
==========================================
+ Hits         1190     1454     +264     
- Misses        179      226      +47     
- Partials       67       78      +11     
Flag Coverage Δ
java ∅ <ø> (?)
javascript 81.98% <ø> (?)
python 82.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ui/src/NavBar/NavBar.tsx 100.00% <0.00%> (ø)
ui/src/EmptyMessageView/EmptyMessageView.tsx 100.00% <0.00%> (ø)
ui/src/ConfigLog4j.ts 100.00% <0.00%> (ø)
ui/src/index.tsx 0.00% <0.00%> (ø)
ui/src/TableListing/TableListing.tsx 93.10% <0.00%> (ø)
ui/src/App.tsx 82.45% <0.00%> (ø)
ui/src/Contents/Contents.tsx 16.66% <0.00%> (ø)
ui/src/utils/api-wrapper.tsx 100.00% <0.00%> (ø)
ui/src/ContentView/ContentView.tsx 93.93% <0.00%> (ø)
ui/src/NotFound/NotFound.tsx 100.00% <0.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 12 '22 16:07 codecov[bot]

Is the description still up-to-date? This link in particular seems to be broken: https://github.com/snazy/nessie-integration-tests/

dimas-b avatar Aug 15 '22 16:08 dimas-b

just looks like nothing may have been tested (or at least i didnt find a test summary or the like)

all actual tests are integration tests - via 'intTest`

snazy avatar Aug 16 '22 08:08 snazy

all actual tests are integration tests - via 'intTest`

my point was that the gradle build gives no feedback on what / how many tests have been executed

XN137 avatar Aug 16 '22 08:08 XN137