nessie icon indicating copy to clipboard operation
nessie copied to clipboard

Add test cases for compaction with NessieCatalog

Open ajantha-bhat opened this issue 2 years ago • 3 comments

fixes #4589 , #4075

ajantha-bhat avatar Jun 28 '22 15:06 ajantha-bhat

Codecov Report

Base: 80.15% // Head: 78.39% // Decreases project coverage by -1.75% :warning:

Coverage data is based on head (c48ac31) compared to base (a9fa1ac). Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4590      +/-   ##
============================================
- Coverage     80.15%   78.39%   -1.76%     
+ Complexity     3199     3140      -59     
============================================
  Files           424      424              
  Lines         14514    14514              
  Branches       1500     1500              
============================================
- Hits          11633    11378     -255     
- Misses         2324     2602     +278     
+ Partials        557      534      -23     
Flag Coverage Δ
java 77.64% <ø> (-2.01%) :arrow_down:
javascript 81.98% <ø> (ø)
python 83.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/org/projectnessie/quarkus/cli/NessieInfo.java 0.00% <0.00%> (-100.00%) :arrow_down:
...e/versioned/persist/mongodb/MongoClientConfig.java 0.00% <0.00%> (-100.00%) :arrow_down:
...va/org/projectnessie/quarkus/cli/CheckContent.java 0.00% <0.00%> (-89.70%) :arrow_down:
...rg/projectnessie/quarkus/cli/ImportRepository.java 0.00% <0.00%> (-74.03%) :arrow_down:
...rg/projectnessie/quarkus/cli/ExportRepository.java 0.00% <0.00%> (-73.14%) :arrow_down:
...org/projectnessie/quarkus/cli/EraseRepository.java 0.00% <0.00%> (-72.23%) :arrow_down:
...ava/org/projectnessie/quarkus/cli/BaseCommand.java 0.00% <0.00%> (-22.23%) :arrow_down:
.../java/org/projectnessie/quarkus/cli/NessieCli.java 0.00% <0.00%> (-16.67%) :arrow_down:
...ed/persist/adapter/spi/TracingDatabaseAdapter.java 58.13% <0.00%> (-15.12%) :arrow_down:
...ojectnessie/quarkus/cli/NessieVersionProvider.java 0.00% <0.00%> (-12.50%) :arrow_down:
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 28 '22 15:06 codecov[bot]

This PR deserves a rebase

snazy avatar Jul 05 '22 12:07 snazy

Version parsing looks buggy and there are a couple of unnecessary changes/duplications in this PR.

Modified the parsing to be string based and did some refactoring.

ajantha-bhat avatar Aug 08 '22 12:08 ajantha-bhat

@snazy : Can you please take a look at this? I have rebased now.

It will help in closing two issues (https://github.com/projectnessie/nessie/issues/4589 , https://github.com/projectnessie/nessie/issues/4075)

ajantha-bhat avatar Sep 07 '22 07:09 ajantha-bhat