Fix agent portrayal dict deprecation warnings in tests

[falloficarus22]

Summary

This PR addresses part of issue #2904 (section 1.1) by eliminating FutureWarning messages related to deprecated dict-based agent portrayals in the visualization test suite.

Changes Made

• tests/test_examples_viz.py: Converted 9 agent portrayal functions to AgentPortrayalStyle.
• Fixed test_boltzmann_wealth_model (invalid color arg) and test_sugarscape_g1mt_model (flaky assertion).
• tests/test_solara_viz_updated.py: Converted dict-based portrayal to AgentPortrayalStyle.
• tests/test_backends.py: Updated to use AgentPortrayalStyle and added tests for deprecated dict-based portrayal wrapped with pytest.warns(FutureWarning) to verify backward compatibility.

Impact

• Eliminates FutureWarning: Returning a dict from agent_portrayal is deprecated messages from the test suite.
• Verifies deprecated dict-based portrayal still works (backward compatibility) while emitting the expected warning.
• All visualization tests passing.
• Code follows new Mesa API standards using AgentPortrayalStyle.

Testing

Ran the following tests successfully:

pytest tests/test_examples_viz.py tests/test_solara_viz_updated.py tests/test_backends.py -v

Result

All deprecation warnings related to agent portrayal are properly handled and visualization tests pass locally.

[EwoutH]

Thanks!

Would you like to give a shot at fixing all remaining agent_portrayal warnings?

[github-actions[bot]]

Performance benchmarks:

Model	Size	Init time [95% CI]	Run time [95% CI]
BoltzmannWealth	small	🔴 +7.9% [+6.8%, +9.0%]	🔵 -0.2% [-0.4%, -0.0%]
BoltzmannWealth	large	🔵 -2.8% [-15.1%, +7.2%]	🔴 +9.1% [+5.5%, +12.8%]
Schelling	small	🔵 -0.3% [-0.5%, -0.1%]	🔵 -0.6% [-0.8%, -0.4%]
Schelling	large	🔵 +7.9% [-0.2%, +21.5%]	🔴 +22.8% [+7.4%, +45.9%]
WolfSheep	small	🔵 +0.1% [-0.2%, +0.4%]	🔵 -1.6% [-1.7%, -1.5%]
WolfSheep	large	🔵 +0.1% [-2.3%, +2.2%]	🔵 +13.1% [-28.2%, +59.2%]
BoidFlockers	small	🔵 -1.5% [-1.9%, -1.0%]	🔵 +0.1% [-0.1%, +0.3%]
BoidFlockers	large	🔵 -2.0% [-2.4%, -1.7%]	🔵 -0.1% [-0.4%, +0.1%]

[falloficarus22]

Thanks!

Would you like to give a shot at fixing all remaining agent_portrayal warnings?

Sure, will try

[falloficarus22]

Hey @EwoutH , please check if the fixes I applied are correct and worth merging this PR.

[falloficarus22]

Hey @EwoutH verified the backward compatibilty too.

[EwoutH]

@Sahil-Chhoker I think it looks good, could you give a final check?

[falloficarus22]

Hey @Sahil-Chhoker , I've updated the test to use color=agent.wealth. I came across a bug in mpl_space_drawing.py: the backend was attempting to copy the scalar color value (an integer in this case) directly to edgecolors, which caused Matplotlib to crash.

I’ve pushed a fix for that backend issue along with the updated test, so AgentPortrayalStyle now correctly handles scalar values for colormapping."

Let me know if I'm wrong or if I need to change anything.

[Sahil-Chhoker]

Sorry for the delay @falloficarus22, and thanks for tracking the bug, this is indeed the right fix for it but can you make a separate PR with just the fix since this PR is only for the tests, first we'll merge the fix then this PR.

[falloficarus22]

Sorry for the delay @falloficarus22, and thanks for tracking the bug, this is indeed the right fix for it but can you make a separate PR with just the fix since this PR is only for the tests, first we'll merge the fix then this PR.

Okay, will do.

[falloficarus22]

Good Work!

Thanks!