mesa icon indicating copy to clipboard operation
mesa copied to clipboard

JupyterViz: the default grid space drawer doesn't scale to large size

Open rht opened this issue 2 years ago • 5 comments

Describe the bug

Here is Schelling space for 60x60: 2023-07-24-102909_468x350_scrot

Expected behavior

Should either scale down the circle marker size automatically, or scale up the figure size automatically.

rht avatar Jul 25 '23 10:07 rht

I vote for scaling up the figure size (which I'm understanding as allocating more space for the agent space figure on the page). Not sure how you would determine the threshold for this - would it have to be user configurable, or could a certain grid size automatically require 3/4 of the width, full width?

rlskoeser avatar Sep 13 '23 14:09 rlskoeser

I think we should do both simultaneously.

rht avatar Sep 15 '23 07:09 rht

I started looking into this-- some upfront ideas here:

  1. If we need to make the figure scalable , I would be better if we make the plots one per row (so that the scaling can be done to the whole screen).

  2. I think it would be better to implement it as a test feature that can be enabled via a checkbox.

  3. The agents size looks straight forward to scale based on number of agents. I look into ways to scale the figure. GridDraggable in solara looks like a promising feature in this regard.

ankitk50 avatar Sep 25 '23 11:09 ankitk50

There shouldn't be upfront customization from the user unless necessary. This should behave like how LaTeX renders documents, where people focus on the content of the writing, not the layout. Automatically deciding when to use the entire row or not, scaling down marker size, increasing figure size, should be the library's responsibility.

rht avatar Sep 25 '23 15:09 rht

Sure, I have opened a draft PR #1820.

ankitk50 avatar Sep 25 '23 16:09 ankitk50