mesa-geo
mesa-geo copied to clipboard
ci: merge setup.cfg into pyproject.toml
We had two separated files, setup.cfg
and pyproject.toml
because some fields were marked as experimental back when they were created: https://github.com/projectmesa/mesa-geo/pull/54#issuecomment-1093635010. Now that Mesa uses only pyproject.toml
, it would be nice to follow its convention, and making it easier to maintain too.
For example in pyproject.toml
we have
https://github.com/projectmesa/mesa-geo/blob/574e3a6c0fd49d6cf6e1cdc5dda72407517c3c47/pyproject.toml#L5
whereas in setup.cfg
it is
https://github.com/projectmesa/mesa-geo/blob/574e3a6c0fd49d6cf6e1cdc5dda72407517c3c47/setup.cfg#L33
something that I forgot to update in https://github.com/projectmesa/mesa-geo/pull/186.
I think we should also remove the setup.py in that case. I think that's still leading?
I think this is a good start: pyproject-toml
Only thing I don't know how to handle is the scripts in setup.py. Are those still essential?
Feel free to continue working on that branch.
Yes we still need to install js/css dependencies in setup.py. This part for Mesa has been moved into the separate repo https://github.com/projectmesa/mesa-viz-tornado. Mesa-Geo probably doesn't need to do this.
Implemented in https://github.com/projectmesa/mesa-geo/pull/208. Closing.