mesa-geo icon indicating copy to clipboard operation
mesa-geo copied to clipboard

Integrate Jupyterviz

Open tpike3 opened this issue 10 months ago • 4 comments

Unfortunately with my current job, I am always behind so this is not very clean or optimized however this integrates jupyter_viz into mesa_geo

Please also see mesa-examples pull request for browser and jupyter examples

TODO: fix the jupyter version when you try and expand from the cell output to full screen

tpike3 avatar Apr 07 '24 13:04 tpike3

Codecov Report

Attention: Patch coverage is 0.68027% with 146 lines in your changes are missing coverage. Please review.

Project coverage is 64.34%. Comparing base (ce501b6) to head (699f1ac). Report is 5 commits behind head on main.

:exclamation: Current head 699f1ac differs from pull request most recent head f3b4cd2. Consider uploading reports for the commit f3b4cd2 to get more accurate results

Files Patch % Lines
mesa_geo/geoexperimental/geojupyter_viz.py 0.00% 75 Missing and 2 partials :warning:
mesa_geo/geoexperimental/leaflet_viz.py 0.00% 67 Missing :warning:
mesa_geo/geoexperimental/__init__.py 0.00% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #199       +/-   ##
===========================================
- Coverage   78.21%   64.34%   -13.87%     
===========================================
  Files          10       13        +3     
  Lines         693      833      +140     
  Branches      151      186       +35     
===========================================
- Hits          542      536        -6     
- Misses        127      268      +141     
- Partials       24       29        +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 07 '24 13:04 codecov[bot]

The code shouldn't be duplicated as much as possible, otherwise it is much more difficult to maintain.

rht avatar Apr 08 '24 02:04 rht

The code shouldn't be duplicated as much as possible, otherwise it is much more difficult to maintain.

Removed the draw_grid code from components as the assumption is it will not be used since users will put everything on maps.

Are you also saying it should import more from Mesa (e.g. the matplotlib)?

tpike3 avatar Apr 08 '24 10:04 tpike3

Still rushing through this but let me know what else I need to do so we can get this release before AAG.

Sorry for the hassle

tpike3 avatar Apr 09 '24 10:04 tpike3