Peter Vullings

Results 60 comments of Peter Vullings

Fixed segmentation fault in tests.

@hermet Ready for review!

@JSUYA Thank you for the review. I have made the suggested changes. Please let me know if you have other suggestions and I am happy to make them. I did...

@hermet Thank you for the review. I have addressed all your comments. The biggest changes are: 1. Polygon (triangle) now expects normalized UV coordinates. In order to do this, the...

@hermet Thanks for remembering the duplicate() function. I also double-checked all comments and fixed some additional linting. The only difference now that I can see from your comments is `triangleCnt`...

@hermet @mmaciola I would really like blending modes supported :) What is required to this work to make it suitable for ThorVG? I am happy to contribute. Hermet do you...

Please note that I was getting test errors before the static image loaders, too. I do not think they are related to the new work :)

I have tried with the latest code. Just one test error now, but it's a new one: ```` ../test/testPicture.cpp(358): FAILED: {Unknown expression after the reported line} due to a fatal...

@JSUYA I just tried it now. Still the same error - unfortunately it did not resolve the issue. [testlog.txt](https://github.com/Samsung/thorvg/files/7458308/testlog.txt) ```` ../test/testPicture.cpp(358): FAILED: {Unknown expression after the reported line} due to...

@JSUYA All tests pass! ``` All tests passed (1137 assertions in 73 test cases) ------------------------------------------------------------------------------ Ok: 1 Expected Fail: 0 Fail: 0 Unexpected Pass: 0 Skipped: 0 Timeout: 0 ```...