Lock the screen when no activity is set

[tbabej]

This forces the user to always have some activity set, if he wants to work on the workstation.

[tbabej]

I should also say that this is configurable behaviour via the GUI, that is turned off by default.

[tbabej]

No plans to merge this request? I use it everyday, and it might be quite useful to others as well.

[toupeira]

Hi there, please rebase on master and I'll take a look!

[tbabej]

Done!

[toupeira]

I get the following exception when trying to open the preferences:

Traceback (most recent call last):
  File "/home/mak/src/hamster/src/hamster/overview.py", line 492, in on_prefs_clicked
    dialogs.prefs.show(self)
  File "/home/mak/src/hamster/src/hamster/lib/configuration.py", line 149, in show
    dialog = self.get_dialog_class()(parent, **kwargs)
  File "/home/mak/src/hamster/src/hamster/preferences.py", line 161, in __init__
    self.load_config()
  File "/home/mak/src/hamster/src/hamster/preferences.py", line 210, in load_config
    self.get_widget("workspace_tracking_name").set_active("name" in conf.get("workspace_tracking"))
AttributeError: 'NoneType' object has no attribute 'set_active'

[elbenfreund]

Thank you for your feedback, it is much appreciated.

Project hamster and its various sub-components is currently undergoing some major changes. We prepare the introduction of a rewritten codebase for most of the underlying functionality. A direct consequence of this is that it is unlikely that any open/new bugs within the current/old codebase will be fixed (unless someone steps up and offers to do so) as most resources currently available will be invested in making the rewrite prime time ready.

If you are still interested in working on the new codebase (repositories: hamster-lib/cli/gtk/dbus) we would be most thrilled. Please feel free to either open a new issue with the relevant repository and/or join the discussion on the mailinglist. For more context please see our website.

Thanks for your interest and support! Eric.

[toupeira]

@elbenfreund the website link is broken, you forgot the http:// ;-)

[elbenfreund]

Thank you! :)

Are you sure you don't want to stick around and take care of the extension or such?

[toupeira]

Well I just noticed this because I was still subscribed to the issue ;-) And the truth is I barely touched that code and am not very familiar with Gnome Shell internals... you can add me back to the Developers team if you want, I only left the whole organization because it seemed that's the only way to remove my Owner status. But I'm also fine with just submitting PRs if I run into something :)

[GeraldJansen]

Considering #470, #493 and #494, this PR should probably be closed.

[mwilck]

Considering #470, #493 and #494, this PR should probably be closed.

Yes. More importantly, we'd need to clarify if we actually want this feature. The way it's currently implemented I suggest to reject it. I, personally, would totally hate to be locked out automatically, just because I'd forgotten to set an activity. OK, it's disabled by default. But even then, at least I'd require a few warning notifications before actually locking the screen. IMO the "no activity" notification is absolutely sufficient to remind people of setting an activity.

[matthijskooijman]

W00ps, i was a little overzealous in cleanup @ederag's comment. Turns out it still relevant, since there is a "Pending check" for CLA that can probably never realized. Here's the deleted comment:

There will never be any CLA on this code. Please disregard the wrong checks (#589).

Sorry for the noise.