glow icon indicating copy to clipboard operation
glow copied to clipboard

Add parameters to control max iterations and tolerance in logistic regression fit

Open henrydavidge opened this issue 4 years ago • 1 comments

We should allow the user to configure these parameters, especially for the approximate Firth fit. cc @bboutkov since I believe this came up in your tests.

logistic_regression definition: https://github.com/projectglow/glow/blob/master/python/glow/gwas/log_reg.py#L24-L33

henrydavidge avatar Jan 27 '21 15:01 henrydavidge

Thanks for opening this. I have the code ready and it seems to be working. Unfortunately we have some updates to our open source contribution policies that I need to review, but should be back here shortly.

bboutkov avatar Jan 28 '21 19:01 bboutkov