glow icon indicating copy to clipboard operation
glow copied to clipboard

Move alpha into grouping expression for ridge regression fit

Open karenfeng opened this issue 4 years ago • 2 comments

During RidgeRegression.fit(), we group on ['sample_block', 'label'] but not on 'alpha'. This becomes a limiting factor on our scalability due to PyArrow limits, which constrain the number of 8-byte float values in a vector to 132,152,839; see the limits described in https://github.com/projectglow/glow/pull/282.

karenfeng avatar Sep 02 '20 16:09 karenfeng

@karenfeng did we end up doing this one?

henrydavidge avatar Jan 19 '21 01:01 henrydavidge

No, I believe this is unchanged: https://github.com/projectglow/glow/blob/a63306ee307e9209bce0ea3f7f6d74d60bb8ab32/python/glow/wgr/linear_model/ridge_model.py#L217

karenfeng avatar Jan 19 '21 20:01 karenfeng