fluent icon indicating copy to clipboard operation
fluent copied to clipboard

Allow empty messages and terms

Open stasm opened this issue 7 years ago • 3 comments

Right now the following are syntax errors:

# Terms must have a value.
-term =
# Messages must have a value or at least one attribute.
message =

I wonder if it would make sense to make them valid syntax, even if they aren't valid translations. I'd expect tools like compare-locales to report errors about them and Pontoon to treat them as untranslated. But it might be useful to write down a list of identifiers to fill in later on and not have your editor throw errors on each line at you.

(Low priority food for thought.)

stasm avatar Feb 09 '18 12:02 stasm

I'm in favor of this change.

zbraniecki avatar Feb 09 '18 15:02 zbraniecki

I think keeping these as parse errors is good.

They're in the way of runtime fallback, they're showing up as translated strings in pontoon, etc.

Pike avatar Feb 09 '18 16:02 Pike

I think keeping these as parse errors is good.

+1. Without concatenations, I don't expect us to have a lot of use cases for empty strings, most of the time those are just mistakes.

For the record, this helped me fix at least a dozen broken strings across locales in the last update.

flodolo avatar Feb 09 '18 16:02 flodolo