fluent.js icon indicating copy to clipboard operation
fluent.js copied to clipboard

[fluent-react] Support ref forwarding in `withLocalization`

Open akdetrick opened this issue 2 years ago • 1 comments

The withLocalization HOC is unable to forward refs to the wrapped component.

This would be useful for legacy projects that rely on class-based React components. The withLocalization HOC is the best option to provide the getString interface, but if the wrapped component relies on a ref being applied, withLocalization won't work.

There is an easy workaround, which is for developers to roll their own HOC that forwards a ref, composed from useLocalization. It may be a good feature to add to the official fluent react bindings.

i18next has a similar HOC, but supports an option to forward a ref through to the wrapped component: https://react.i18next.com/latest/withtranslation-hoc#use-ref-greater-than-v10.6.0

akdetrick avatar Sep 07 '22 15:09 akdetrick

Yeah, that makes sense. Would you be willing/interested in submitting a PR for that, probably by adding an optional second arg like { forwardRef?: boolean } to withLocalization()?

eemeli avatar Sep 09 '22 12:09 eemeli