fluent-rs icon indicating copy to clipboard operation
fluent-rs copied to clipboard

Published 20 hours ago • verified publisher icon projectfluent

sync feature for ressource threading

Open d34db4b3 opened this issue 3 years ago • 4 comments

Hi, I think it could be interesting to allow using the elsa::sync::FrozenMap for ressource sharing between threads.

Let me known what you think.

d34db4b3 avatar Mar 07 '22 10:03 d34db4b3

Thank you for the PR!

@Manishearth does that look reasonable to you?

zbraniecki avatar Apr 22 '22 18:04 zbraniecki

It's typically not a good idea to swap out major internal implementation details via cargo features in ways that are externally visible or have perf implications, since cargo features are resolved globally.

It would be better to make it possible to use either backend, I think

Manishearth avatar Apr 22 '22 18:04 Manishearth

I thought about this and I also think it would be better to be able to use either. I used the feature to avoid altering the current behavior of the crate. I can create a new pull request if you have any advise/opinion about how it should be done.

d34db4b3 avatar Apr 22 '22 18:04 d34db4b3

Yes please, I agree with Manish. Let's get a fluent_resmgr::sync::* equivalents for sync use. You can macro it out to avoid duplications.

zbraniecki avatar Apr 22 '22 20:04 zbraniecki

This PR is a little stale, and as I'm triaging and handling the pull request queue I'm going to go ahead and close it for now.

gregtatum avatar Oct 27 '22 15:10 gregtatum