[BUG] ... Crash while running on list of websites

[dragonked2]

Is there an existing issue for this?

• [x] I have searched the existing issues.

Current Behavior

hello the script has crashed with this error

github.com/projectdiscovery/fastdialer/fastdialer/utils.(*DialWrap).dialParallel(0x12ad9c0c421?, {0x46bd868?, 0xc01c4f63f0?}, {0xc021076510?, 0x0?, 0x1000000000000?}, {0x0?, 0x27d6bd81c68?, 0xc058105d40?}, {0x3a36fe8, ...}, ...)
        github.com/projectdiscovery/[email protected]/fastdialer/utils/dialwrap.go:301 +0x48a fp=0xc05370f128 sp=0xc05370ee50 pc=0x17f4f0a
github.com/projectdiscovery/fastdialer/fastdialer/utils.(*DialWrap).dial(0xc017f49ec0, {0x46bd868, 0xc01c4f63f0})
        github.com/projectdiscovery/[email protected]/fastdialer/utils/dialwrap.go:252 +0x216 fp=0xc05370f200 sp=0xc05370f128 pc=0x17f4796
github.com/projectdiscovery/fastdialer/fastdialer/utils.(*DialWrap).DialContext(0xc017f49ec0, {0x46bd868, 0xc01c4f63f0}, {0x4687cd0?, 0x0?}, {0xc01ab74daa?, 0xc01a70e5b0?})
        github.com/projectdiscovery/[email protected]/fastdialer/utils/dialwrap.go:110 +0x11a fp=0xc05370f2b0 sp=0xc05370f200 pc=0x17f2e5a
github.com/projectdiscovery/fastdialer/fastdialer.(*Dialer).dialIPS(0xc000a44080, {0x46bd868, 0xc01c4f63f0}, {0x469ff40, 0xc017f49ec0}, 0xc047043600)
        github.com/projectdiscovery/[email protected]/fastdialer/dialer_private.go:239 +0xd58 fp=0xc05370f578 sp=0xc05370f2b0 pc=0x18a40b8
github.com/projectdiscovery/fastdialer/fastdialer.(*Dialer).dial(0xc000a44080, {0x46bd868?, 0xc01c4f6380?}, 0xc047043600)
        github.com/projectdiscovery/[email protected]/fastdialer/dialer_private.go:185 +0xb5e fp=0xc05370f8f8 sp=0xc05370f578 pc=0x18a2a9e
github.com/projectdiscovery/fastdialer/fastdialer.(*Dialer).DialTLSWithConfig(0xc05370f978?, {0x46bd868, 0xc01c4f6380}, {0x3a36fe8, 0x3}, {0xc058105d40, 0x15}, 0xc04e076820)
        github.com/projectdiscovery/[email protected]/fastdialer/dialer.go:225 +0xee fp=0xc05370f930 sp=0xc05370f8f8 pc=0x18a0c8e
github.com/projectdiscovery/fastdialer/fastdialer.(*Dialer).DialTLS(0xc000a44080, {0x46bd868, 0xc01c4f6380}, {0x3a36fe8, 0x3}, {0xc058105d40, 0x15})
        github.com/projectdiscovery/[email protected]/fastdialer/dialer.go:215 +0xe6 fp=0xc05370f980 sp=0xc05370f930 pc=0x18a0a66
github.com/projectdiscovery/nuclei/v3/pkg/protocols/http/httpclientpool.wrappedGet.func1({0x46bd868, 0xc01c4f6380}, {0x3a36fe8, 0x3}, {0xc058105d40, 0x15})
        github.com/projectdiscovery/nuclei/v3/pkg/protocols/http/httpclientpool/clientpool.go:271 +0xee fp=0xc05370f9e0 sp=0xc05370f980 pc=0x2895c6e
net/http.(*Transport).customDialTLS(0x135c505?, {0x46bd868?, 0xc01c4f6380?}, {0x3a36fe8?, 0xc05370fb00?}, {0xc058105d40?, 0x0?})
        net/http/transport.go:1335 +0x4a fp=0xc05370fa30 sp=0xc05370f9e0 pc=0x13be88a
net/http.(*Transport).dialConn(0xc055c312c0, {0x46bd868, 0xc01c4f6380}, {{}, 0x0, {0xc04e4c6ff0, 0x5}, {0xc058105d40, 0x15}, 0x0})
        net/http/transport.go:1601 +0x3df fp=0xc05370fed8 sp=0xc05370fa30 pc=0x13c0bff
net/http.(*Transport).dialConnFor(0x13c29e5?, 0xc055c658c0)
        net/http/transport.go:1467 +0x9f fp=0xc05370ffc0 sp=0xc05370fed8 pc=0x13bfb1f
net/http.(*Transport).queueForDial.func1()
        net/http/transport.go:1436 +0x25 fp=0xc05370ffe0 sp=0xc05370ffc0 pc=0x13bfa45
runtime.goexit()
        runtime/asm_amd64.s:1650 +0x1 fp=0xc05370ffe8 sp=0xc05370ffe0 pc=0x1062fc1
created by net/http.(*Transport).queueForDial in goroutine 4905588
        net/http/transport.go:1436 +0x3cb

C:\Users\or0to\Downloads>

Expected Behavior

it should be working correctly without any issues

Steps To Reproduce

nuclei -l she1.txt -t temp/http/ -o results.txt -c 100 -rl 500 -severity high,critical,medium

Relevant log output

Environment

- OS: 
- Nuclei: 
- Go: 
Windows 11 pro

Anything else?

idk the old version worked perfectly with no issues

[A3g00n]

i have same problem

[mastercho]

Interesting i got same issue, now rerunning list to see if is some memory leak or site issue

[huangjinjinyu]

i have same problem

[mastercho]

After i rerun list with more free RAM didnt got the error, so somewhere happens to be memory leak

[matejsmycka]

Create issue also here: https://github.com/projectdiscovery/fastdialer

Error is here: https://github.com/projectdiscovery/fastdialer/blob/f8e867309dce5eb5ebd6faacd7c6df82b43f4b8b/fastdialer/utils/dialwrap.go#L298

Maybe variable earliest is not initialized in some cases?

Just guessing tho

[ifoxhz]

in func (d *DialWrap) dialParallel(ctx context.Context, primaries, fallbacks []net.IP, network string, port string) start 2 routines go startRacer(primaryCtx, true) go startRacer(fallbackCtx, false)

when dialParallel return , and call defer function " close(returned)" , the routine startRacer would write a close channel. this will triger panic. But the logs should output "panic: close of closed channel", but it did not. That's odd.

[Mehran-Seifalinia]

Hi team, I investigated the crash issue reported here and found it caused by missing nil checks in the fastdialer’s dialParallel method. I submitted a PR that adds necessary nil checks and fixes a variable typo, which should resolve this crash. Please review: https://github.com/projectdiscovery/fastdialer/pull/475

Thanks!

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

[Mzack9999]

This should be now fixed and not reproducible anymore with the new internal architecture using independent dialers with different execution ids. I'm closing the issue and it will be reopened if the issue persists.