nuclei icon indicating copy to clipboard operation
nuclei copied to clipboard

Implement more granular, issue tracker level filtering

Open leonjza opened this issue 1 year ago • 1 comments

Proposed changes

This PR is an implementation proposal for #4779, making it possible to further apply issue/tag filters to issue trackers via a new, per tracker allow-list / deny-list options key. This makes it possible to have everything written via an exporter, but only certain issues logged in a tracker.

I wanted to reuse the existing code used for a Filter, but to prevent a cyclic dependency in issue trackers I had to move that out to a new package. Next, I had to extend the Tracker interface to include a ShouldFilter. I don't particularly like this because of the duplicate code, but I am hesitant to change the internal structure too much.

Checklist

  • [x] Pull request is created against the dev branch
  • [x] All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] I have added necessary documentation (if appropriate)

leonjza avatar Feb 21 '24 07:02 leonjza

Thanks for this contribution @leonjza - our team will take a look.

olearycrew avatar Feb 21 '24 15:02 olearycrew