naabu icon indicating copy to clipboard operation
naabu copied to clipboard

Issue with nmap flag input

Open ehsandeep opened this issue 2 years ago • 1 comments

Naabu version:

master,dev

Current Behavior:

nmap binary being accepted in the input.

Example:

echo hackerone.com | naabu -p 80 -nmap-cli "nmap -sV" -silent

Expected Behavior:

nmap cmd should be accepted as input and substitute to nmap

Example:

echo hackerone.com | naabu -p 80 -nmap-cli "-sV" -silent

ehsandeep avatar Jul 23 '22 16:07 ehsandeep

@ehsandeep I think initially this was the idea. Still, later, it was opted to accept generic commands (nmap can be located anywhere or be available under aliases) and append the list of space-separated ips with -p and comma-separated ports for post-processing purposes. Do you think we should only execute the nmap binary?

Mzack9999 avatar Jul 26 '22 07:07 Mzack9999

^ @ehsandeep could you confirm?

Mzack9999 avatar Nov 21 '22 18:11 Mzack9999

^ @ehsandeep could you confirm?

Yes, as part of this feature, we should keep limited to nmap binary and execute only if nmap is configured / available to the users path, otherwise we can error it out.

ehsandeep avatar Nov 21 '22 19:11 ehsandeep