dnsx icon indicating copy to clipboard operation
dnsx copied to clipboard

Export `runner` to use as lib

Open gnuletik opened this issue 1 year ago • 3 comments

Please describe your feature request:

The runner package is currently located inside internal directory (https://github.com/projectdiscovery/dnsx/tree/main/internal/runner) which makes it unable to load it as a library.

Would it be possible to move internal/runner to libs/runner (or pkg/runner) so it can be imported inside other projects?

Is there a specific reason to put it inside internal? Other projectdiscovery projects like seems to export the runner package. e.g. https://github.com/projectdiscovery/subfinder/tree/master/v2/pkg/runner

Describe the use case of this feature:

We'd like to use the bruteforce feature inside other projects.

If you're okay with this, I can make a PR for the migration. Thanks!

gnuletik avatar Apr 27 '23 12:04 gnuletik

I encountered the same problem, the libs/dnsx package provides too few feature and option

okadwin avatar May 31 '23 07:05 okadwin

@gnuletik, @okadwin, Please provide your thoughts and suggestions on the features you want to see in libs/dnsx. Thanks!

dogancanbakir avatar Sep 22 '23 12:09 dogancanbakir

@dogancanbakir my proposal is to move the internal/runner to runner or pkg/runner.

gnuletik avatar Sep 22 '23 12:09 gnuletik

We have considered your request to export the runner, but have decided that it goes against our current conventions. However, we welcome your suggestions and would be happy to consider incorporating new features into our library. To suggest features, please create a new issue and we will review it as soon as possible. Thank you for your understanding.

dogancanbakir avatar Mar 15 '24 10:03 dogancanbakir