panorama-tab-groups
panorama-tab-groups copied to clipboard
projectdelphai
Have toolbar icon open dropdown menu as in old Tab Groups extension.
It would be nice if the toolbar icon opened a dropdown menu when left clicked, like the old extension did. The dropdown would list all the groups with the active one being highlighted. At the bottom would be an item to open panorama view. This is related and complimentary to #34.
I started a prototype at https://github.com/vaxul/panorama-tab-groups/tree/test/popup
Mainly I'd like to first refactor the tab groups handling. Extract the view independent code and abstract it with f.e. classes which all views can utilise. Than create the different views (popup is one) which should rely on less JavaScript and more CSS.
Is in work. State around 90% done: https://github.com/vaxul/panorama-tab-groups/tree/feature/%23131_add_popup_view
Still a lot of polishing to do.
A good point was brought up in #179 I wonder instead of being able to select groups from the icon, whether you could add that functionality to the arrow key on the tab list. It looks like Containers already hooks into that and it might be simpler for us to do it that way. So clicking on the PTG icon sends you to the view and using the down arrow allows you to switch groups without entering the view.
@projectdelphai please look into my branch for #131 https://github.com/vaxul/panorama-tab-groups/tree/feature/%23131_add_popup_view
- Enable popup view in settings
- Click icon or hit keyboard shortcut
- Use arrow keys and enter to switch to groups/tabs.
I will sum up all features in a PR after I finish the polishing after my holiday.
@crass @projectdelphai Please have look at this Pull Request: https://github.com/projectdelphai/panorama-tab-groups/pull/191
Give it a try and please try to give feedback:
- from a user point of view
- maybe from a developers point of view
It took some months to get it done to this state, so I personally consider its state as feature freeze. There are still some ToDos I'd like to resolve, but maybe not for this merge. I think more in a time frame for v1.0.0 of this extension.