contour icon indicating copy to clipboard operation
contour copied to clipboard

Configure the per-route value for max_grpc_timeout

Open mattalberts opened this issue 5 years ago • 3 comments

Describe the solution you'd like Configure the per-route value for max_grpc_timeout

Anything else you would like to add: With the release of envoyproxy 1.9.0, the meaning of max_grpc_timeout has been updated. Envoy will now add or update the grpc-timeout header to reflect Envoy’s expected timeout.

There appears to be future discussion regarding timeout support for IngressRoute

  • #894
  • #815

I would like to scope this feature request to Ingress (consistent with other exposed timeouts), allowing max_grpc_timeout to be included in the larger discussion for IngressRoute without blocking implementation for Ingress.

Additional context that needs to be clarified, unlike the pre-route timeout, max_grpc_timeout defaults to disabled unless specified. I assume there should be discussion around

  • mirroring the behavior for max_grpc_timeout (e.g. disable unless provided)
  • providing a command-line default to default enable (mirroring behavior and annotation controls for timeout)

Environment:

  • Contour version: v0.10.0
  • Kubernetes version: (use kubectl version): v1.10.11
  • Kubernetes installer & version: N/A
  • Cloud provider or hardware configuration: N/A
  • OS (e.g. from /etc/os-release): N/A

mattalberts avatar Mar 12 '19 18:03 mattalberts