contour
contour copied to clipboard
Fix Gateway API conformance test HTTPRouteHTTPSListener
For a Gateway HTTPS Listeners with unspecified (catchall/wildcard) hostnames, we add a wildcard filter chain
This is to ensure we get a routing failure HTTP response (404) when a request is received that is for an "unknown" fqdn, rather than a connection error because Envoy does not have a filter chain to match
Codecov Report
:x: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 80.13%. Comparing base (30397f1) to head (7d7c19c).
:warning: Report is 15 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| internal/dag/gatewayapi_processor.go | 66.66% | 0 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #7306 +/- ##
==========================================
- Coverage 81.85% 80.13% -1.72%
==========================================
Files 130 130
Lines 15747 15785 +38
==========================================
- Hits 12889 12649 -240
- Misses 2574 2609 +35
- Partials 284 527 +243
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/dag/dag.go | 87.59% <100.00%> (-10.86%) |
:arrow_down: |
| internal/dag/gatewayapi_processor.go | 75.74% <66.66%> (-18.14%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.