contour
contour copied to clipboard
Bump gateway-api to v1.1.0
Fixes: https://github.com/projectcontour/contour/issues/6397
Codecov Report
Attention: Patch coverage is 91.20879% with 8 lines in your changes are missing coverage. Please review.
Project coverage is 81.61%. Comparing base (
c07a0ba) to head (e25e4e5).
Additional details and impacted files
@@ Coverage Diff @@
## main #6398 +/- ##
==========================================
- Coverage 81.63% 81.61% -0.03%
==========================================
Files 133 133
Lines 15862 15858 -4
==========================================
- Hits 12949 12942 -7
- Misses 2619 2621 +2
- Partials 294 295 +1
| Files | Coverage Δ | |
|---|---|---|
| internal/dag/cache.go | 97.00% <100.00%> (-0.03%) |
:arrow_down: |
| internal/dag/policy.go | 95.52% <100.00%> (ø) |
|
| internal/gatewayapi/helpers.go | 88.18% <100.00%> (ø) |
|
| internal/k8s/helpers.go | 57.14% <100.00%> (ø) |
|
| internal/k8s/kind.go | 65.21% <100.00%> (ø) |
|
| internal/provisioner/controller/gatewayclass.go | 71.13% <ø> (ø) |
|
| internal/provisioner/objects/rbac/util/util.go | 100.00% <100.00%> (ø) |
|
| internal/provisioner/scheme.go | 83.33% <100.00%> (ø) |
|
| internal/status/backendtlspolicyconditions.go | 91.37% <100.00%> (ø) |
|
| internal/status/cache.go | 93.22% <100.00%> (ø) |
|
| ... and 4 more |
Looks like HTTPRouteHTTPSListener is failing, it expects a 404 for request to a HTTPS listener with an unknown hostname
Seems like we should either push back on this (expect a TLS error instead) or we'll have to ensure a fallback certificate is configured and enabled so we can terminate TLS and return an HTTP response
Looks like
HTTPRouteHTTPSListeneris failing, it expects a 404 for request to a HTTPS listener with an unknown hostnameSeems like we should either push back on this (expect a TLS error instead) or we'll have to ensure a fallback certificate is configured and enabled so we can terminate TLS and return an HTTP response
hm looks like i approved this test and it passed before, will have to take another look into why its failing in CI
Looks like
HTTPRouteHTTPSListeneris failing, it expects a 404 for request to a HTTPS listener with an unknown hostname Seems like we should either push back on this (expect a TLS error instead) or we'll have to ensure a fallback certificate is configured and enabled so we can terminate TLS and return an HTTP responsehm looks like i approved this test and it passed before, will have to take another look into why its failing in CI
looks like i approved before the negative hostname test was added and didnt re-check it later
opened https://github.com/kubernetes-sigs/gateway-api/issues/3044
Looks like
HTTPRouteHTTPSListeneris failing, it expects a 404 for request to a HTTPS listener with an unknown hostname Seems like we should either push back on this (expect a TLS error instead) or we'll have to ensure a fallback certificate is configured and enabled so we can terminate TLS and return an HTTP responsehm looks like i approved this test and it passed before, will have to take another look into why its failing in CI
looks like i approved before the negative hostname test was added and didnt re-check it later
realized this is probably a contour deficiency, I don't think we generate a filter chain if there is no httproute attached to a listener
upgrade test probably failing since we started reconciling v1alpha3 backendtlspolicy and that has not been applied to the cluster as part of the upgrade
Listener isolation test failing, needs this fix: https://github.com/projectcontour/contour/pull/6162
disabled backendtlspolicy feature in provisioner upgrade test since the upgrade from v1.0.0 to v1.1.0 of gw api removes the old api version and adds v1alpha3 of the resource
i tried instead to install the newer crds as part of the upgrade but the grpcroute crd going to v1 also causes some issues, could be more surgical but this felt easier for now
disabled backendtlspolicy feature in provisioner upgrade test since the upgrade from v1.0.0 to v1.1.0 of gw api removes the old api version and adds v1alpha3 of the resource
i tried instead to install the newer crds as part of the upgrade but the grpcroute crd going to v1 also causes some issues, could be more surgical but this felt easier for now
nvm, just fixed the crd install as part of the upgrade
found a bug when setting multiple disabled features in the provisioner