feature: http buffer filter configuration (#6249)

[ruzmuh]

trafficstars

Proposal for Issue #6249: Introduce two optional command line flags, envoy-http-buffer-max-request-bytes and envoy-https-buffer-max-request-bytes, with default values set to 0. If the value is non-zero, an HTTP buffer filter will be added to the HTTP filter chain immediately after the DefaultFilters() with the max_request_bytes parameter. This configuration allows setting the buffer filter for the entire HTTP listener. In the future, it possible to provide ability to override these values on a per-route basis using bufferperroute.

[github-actions[bot]]

Hi @ruzmuh! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

[github-actions[bot]]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 14d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

• Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
• Mark this PR as fresh by commenting or pushing a commit
• Close this PR
• Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.57%. Comparing base (c3d6cb4) to head (fba7631). Report is 90 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6315   +/-   ##
=======================================
  Coverage   81.56%   81.57%           
=======================================
  Files         133      134    +1     
  Lines       15801    15828   +27     
=======================================
+ Hits        12888    12911   +23     
- Misses       2617     2621    +4     
  Partials      296      296           

Files	Coverage Δ
cmd/contour/servecontext.go	86.02% <100.00%> (+0.07%)	:arrow_up:
internal/contourconfig/contourconfiguration.go	98.70% <100.00%> (+0.01%)	:arrow_up:
internal/envoy/v3/buffer.go	100.00% <100.00%> (ø)
internal/xdscache/v3/listener.go	92.06% <100.00%> (+0.05%)	:arrow_up:
pkg/config/parameters.go	88.07% <100.00%> (+0.04%)	:arrow_up:
cmd/contour/serve.go	22.59% <0.00%> (-0.07%)	:arrow_down:

... and 5 files with indirect coverage changes

[github-actions[bot]]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 14d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

• Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
• Mark this PR as fresh by commenting or pushing a commit
• Close this PR
• Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

[github-actions[bot]]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 14d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

• Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
• Mark this PR as fresh by commenting or pushing a commit
• Close this PR
• Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

[frankh]

can this be reopened? It's a pretty important feature