contour icon indicating copy to clipboard operation
contour copied to clipboard

support httproute to set annotation with "projectcontour.io/response-timeout"

Open Bryce-huang opened this issue 10 months ago • 3 comments

Please describe the problem you have [A clear, concise, description of the problem you are facing. What is the problem that feature X would solve for you?]

The annotation is "projectcontour.io/response-timeout" only support ingress

var annotationsByKind = map[string]map[string]struct{}{
	"Ingress": {
		"ingress.kubernetes.io/force-ssl-redirect":       {},
		"kubernetes.io/ingress.allow-http":               {},
		"kubernetes.io/ingress.class":                    {},
		"projectcontour.io/ingress.class":                {},
		"projectcontour.io/num-retries":                  {},
		"projectcontour.io/response-timeout":             {},
		"projectcontour.io/retry-on":                     {},
		"projectcontour.io/tls-minimum-protocol-version": {},
		"projectcontour.io/tls-maximum-protocol-version": {},
		"projectcontour.io/tls-cert-namespace":           {},
		"projectcontour.io/websocket-routes":             {},
	},
	"Service": {
		"projectcontour.io/max-connections":       {},
		"projectcontour.io/max-pending-requests":  {},
		"projectcontour.io/max-requests":          {},
		"projectcontour.io/max-retries":           {},
		"projectcontour.io/upstream-protocol.h2":  {},
		"projectcontour.io/upstream-protocol.h2c": {},
		"projectcontour.io/upstream-protocol.tls": {},
	},
	"HTTPProxy": {
		"kubernetes.io/ingress.class":     {},
		"projectcontour.io/ingress.class": {},
	},
	"Secret": {
		"projectcontour.io/generated-by-version": {},
	},
}

Bryce-huang avatar Mar 29 '24 02:03 Bryce-huang

Hi @Bryce-huang!

The Gateway API uses different mechanism for setting timeouts.

Did you check this feature https://github.com/projectcontour/contour/releases/tag/v1.28.0

Gateway API: support HTTPRoute request timeouts

Contour now enables end-users to specify request timeouts by setting the [HTTPRouteRule.Timeouts.Request] (https://gateway-api.sigs.k8s.io/reference/spec/#gateway.networking.k8s.io/v1.HTTPRouteTimeouts) parameter. Note that BackendRequest is not yet implemented because without Gateway API support for retries, it's functionally equivalent to Request.

tsaarni avatar Apr 10 '24 05:04 tsaarni

Thanks,I use v1beta1,maybe need migrate to v1

Bryce-huang avatar Apr 11 '24 08:04 Bryce-huang

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Jun 11 '24 00:06 github-actions[bot]

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Jul 15 '24 00:07 github-actions[bot]