contour icon indicating copy to clipboard operation
contour copied to clipboard

test/e2e: Test Upstream TLS settings with Gateway API Routes

Open christianang opened this issue 1 year ago • 3 comments

From #6119, We would like to test upstream TLS i.e BackendTLSPolicy with Gateway API Routes in an e2e test to ensure that Contour has wired up everything correctly. E.g to cover the Gateway processor being wired up properly in serve.go.

christianang avatar Jan 29 '24 19:01 christianang

@sunjayBhatia revisiting this issue. Did we already accomplish this task via https://github.com/projectcontour/contour/pull/6119#discussion_r1468123241. Looking at the test I see that it does check the upstream tls version here:

https://github.com/projectcontour/contour/blob/bc8994801c57fe8c5e611c2a5b3fe2435c292b27/test/e2e/gateway/backend_tls_policy_test.go#L184-L187

Or was there more to this issue.

christianang avatar Feb 14 '24 00:02 christianang

We could also add a check similar to https://github.com/projectcontour/contour/blob/main/test/e2e/httpproxy/backend_tls_test.go where we check the right client cert is sent when contour/envoy are configured with a client cert for upstream TLS

Can do this via an e2e test but I think a featuretests "integration" test should also work fine if one doesn't exist for BackendTLSPolicy in this context

sunjayBhatia avatar Feb 14 '24 17:02 sunjayBhatia

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Apr 15 '24 02:04 github-actions[bot]

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar May 20 '24 00:05 github-actions[bot]