setting NumRetries to -1 does not appear to disable retries

[skriss]

HTTPProxy's numRetries field documents that setting it to -1 disables retries.

In the DAG, if it's set to -1 in the API, then in the DAG representation it's set to 0.

However, when converting to Envoy config, we only set a numRetries value if the DAG value is non-zero. Envoy documents that if num_retries is not specified, then it defaults to a value of 1.

So it seems that setting numRetries to -1 in the API is not actually disabling retries. The only way to disable them would be to not specify a retryPolicy to begin with for a route. I can't really recall the motivation for wanting to support -1 as a way to disable (vs. deleting the retry policy), but since it's documented as being supported, this seems like something we should fix. Note, need to do some actual end-to-end verification to ensure that my observations of the code match the actual runtime behavior.

[github-actions[bot]]

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

• After 60d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

• Mark this Issue as fresh by commenting
• Close this Issue
• Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack