contour icon indicating copy to clipboard operation
contour copied to clipboard

Implementation: External Processing support

Open izturn opened this issue 2 years ago • 20 comments

Signed-off-by: Gang Liu [email protected]

Implementation proposal to address https://github.com/projectcontour/contour/issues/5123

izturn avatar Oct 19 '23 03:10 izturn

Due to the current proposal status, relevant unit tests have not been added yet

izturn avatar Oct 19 '23 05:10 izturn

Codecov Report

Attention: Patch coverage is 18.97233% with 205 lines in your changes missing coverage. Please review.

Project coverage is 80.75%. Comparing base (3e57486) to head (263275f). Report is 13 commits behind head on main.

Files Patch % Lines
internal/dag/httpproxy_processor.go 31.85% 66 Missing and 11 partials :warning:
internal/envoy/v3/listener.go 6.38% 44 Missing :warning:
internal/envoy/v3/route.go 0.00% 36 Missing and 1 partial :warning:
cmd/contour/serve.go 5.55% 17 Missing :warning:
cmd/contour/servecontext.go 11.11% 15 Missing and 1 partial :warning:
internal/xdscache/v3/listener.go 37.50% 10 Missing :warning:
internal/fixture/httpproxy.go 0.00% 4 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5867      +/-   ##
==========================================
- Coverage   81.76%   80.75%   -1.01%     
==========================================
  Files         133      133              
  Lines       15942    16173     +231     
==========================================
+ Hits        13035    13061      +26     
- Misses       2614     2806     +192     
- Partials      293      306      +13     
Files Coverage Δ
internal/dag/dag.go 98.44% <ø> (ø)
internal/sorter/sorter.go 100.00% <ø> (ø)
pkg/config/parameters.go 88.03% <ø> (ø)
internal/fixture/httpproxy.go 82.92% <0.00%> (-8.97%) :arrow_down:
internal/xdscache/v3/listener.go 89.28% <37.50%> (-2.84%) :arrow_down:
cmd/contour/servecontext.go 82.47% <11.11%> (-3.48%) :arrow_down:
cmd/contour/serve.go 22.22% <5.55%> (-0.45%) :arrow_down:
internal/envoy/v3/route.go 75.63% <0.00%> (-4.40%) :arrow_down:
internal/envoy/v3/listener.go 90.79% <6.38%> (-7.66%) :arrow_down:
internal/dag/httpproxy_processor.go 85.89% <31.85%> (-5.52%) :arrow_down:

codecov[bot] avatar Oct 19 '23 06:10 codecov[bot]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Nov 03 '23 00:11 github-actions[bot]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Nov 18 '23 00:11 github-actions[bot]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Dec 08 '23 00:12 github-actions[bot]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Dec 29 '23 00:12 github-actions[bot]

For common use cases, I think support route only external process is a good way to help users to config specific logic for their APIs, in my exprences, only few API need specific logic, rest of APIs are normal.

wilsonwu avatar Jan 29 '24 02:01 wilsonwu

Great work @izturn, this will greatly help with adopting contour as part of our stack.

imranismail avatar Feb 04 '24 23:02 imranismail

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Feb 20 '24 00:02 github-actions[bot]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Apr 24 '24 00:04 github-actions[bot]

ping @clayton-gonsalves

izturn avatar Apr 28 '24 06:04 izturn

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar May 13 '24 00:05 github-actions[bot]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Jun 13 '24 00:06 github-actions[bot]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Jul 03 '24 00:07 github-actions[bot]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Jul 19 '24 00:07 github-actions[bot]

Let's review this PR again, this feature already ran on our product for 2 months, it is stable, we'd like to comtribute to community.

wilsonwu avatar Aug 01 '24 07:08 wilsonwu

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Aug 16 '24 00:08 github-actions[bot]