contour icon indicating copy to clipboard operation
contour copied to clipboard

add per-httpproxy http-version support

Open therealak12 opened this issue 1 year ago • 16 comments

This PR adds a new field to HTTPProxy spec which specifies the HTTP versions to offer for that HTTPProxy. It's used only when spec.tls is set and spec.tcpproxy is not.

A critical use case for the field is when we're serving multiple HTTPProxies where a subset of them use the same wildcard certificate. We can disable http/2 for those utilizing this field while keeping it enabled for others.

Closes #5822

therealak12 avatar Oct 04 '23 13:10 therealak12

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Oct 26 '23 00:10 github-actions[bot]

Just to make this active.

therealak12 avatar Oct 26 '23 05:10 therealak12

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Nov 10 '23 00:11 github-actions[bot]

Could a maintainer please add a release-note/small label to this PR? Appears I don't have access to do so.

image

therealak12 avatar Nov 10 '23 09:11 therealak12

/remove-lifecycle stale

therealak12 avatar Nov 10 '23 19:11 therealak12

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Dec 01 '23 00:12 github-actions[bot]

/remove-lifecycle stale

therealak12 avatar Dec 01 '23 02:12 therealak12

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Dec 18 '23 00:12 github-actions[bot]

/remove-lifecycle stale

therealak12 avatar Dec 18 '23 06:12 therealak12

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Jan 03 '24 00:01 github-actions[bot]

/remove-lifecycle stale

therealak12 avatar Jan 03 '24 06:01 therealak12

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 78.78%. Comparing base (7feb49e) to head (d5a24c2). Report is 240 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5802      +/-   ##
==========================================
+ Coverage   78.61%   78.78%   +0.17%     
==========================================
  Files         138      138              
  Lines       19231    19780     +549     
==========================================
+ Hits        15118    15584     +466     
- Misses       3824     3891      +67     
- Partials      289      305      +16     
Files Coverage Δ
internal/dag/dag.go 98.70% <ø> (ø)
internal/dag/httpproxy_processor.go 91.66% <88.88%> (-0.26%) :arrow_down:
internal/xdscache/v3/listener.go 91.39% <80.00%> (-0.66%) :arrow_down:

... and 49 files with indirect coverage changes

codecov[bot] avatar Jan 06 '24 11:01 codecov[bot]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Feb 13 '24 00:02 github-actions[bot]

still needed

m-yosefpor avatar Feb 16 '24 12:02 m-yosefpor

Kindly ping @therealak12 Could you resolve what Sunjay mentioned. Thank you!

lubronzhan avatar Feb 17 '24 05:02 lubronzhan

Kindly ping @therealak12 Could you resolve what Sunjay mentioned. Thank you!

Waiting for this: https://github.com/projectcontour/contour/pull/5802#discussion_r1443650964

therealak12 avatar Feb 17 '24 08:02 therealak12

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Mar 13 '24 00:03 github-actions[bot]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Apr 13 '24 00:04 github-actions[bot]