contour icon indicating copy to clipboard operation
contour copied to clipboard

internal/dag: Gateway Listeners with invalid references should have reason RefNotPermitted

Open sunjayBhatia opened this issue 3 years ago • 2 comments

See https://github.com/kubernetes-sigs/gateway-api/pull/1305

Fixes conformance test failures on main

sunjayBhatia avatar Aug 10 '22 16:08 sunjayBhatia

Codecov Report

Merging #4664 (c5dafb3) into main (fc49f3b) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4664      +/-   ##
==========================================
- Coverage   76.13%   76.11%   -0.02%     
==========================================
  Files         140      140              
  Lines       13093    13093              
==========================================
- Hits         9968     9966       -2     
- Misses       2869     2871       +2     
  Partials      256      256              
Impacted Files Coverage Δ
internal/dag/gatewayapi_processor.go 94.16% <100.00%> (ø)
internal/sorter/sorter.go 97.59% <0.00%> (-1.21%) :arrow_down:

codecov[bot] avatar Aug 10 '22 16:08 codecov[bot]

this is one of those changes where we have a conflict between main of Contour + the latest GW API conformance release

sunjayBhatia avatar Aug 10 '22 17:08 sunjayBhatia

this is one of those changes where we have a conflict between main of Contour + the latest GW API conformance release

Yeah, I guess this brings up a new issue here - if we merge this, then main Gateway conformance will pass, but PR Gateway conformance will start failing since this is not compatible with the v0.5.0 conformance tests.

Perhaps it makes sense to hold this PR open until the upstream conformance change is included in a released version (hopefully v0.5.1)?

skriss avatar Aug 15 '22 14:08 skriss

this is one of those changes where we have a conflict between main of Contour + the latest GW API conformance release

Yeah, I guess this brings up a new issue here - if we merge this, then main Gateway conformance will pass, but PR Gateway conformance will start failing since this is not compatible with the v0.5.0 conformance tests.

Perhaps it makes sense to hold this PR open until the upstream conformance change is included in a released version (hopefully v0.5.1)?

yeah, was thinking that would probably have to be the case

submitted: https://github.com/kubernetes-sigs/gateway-api/issues/1328 to start the conversation

sunjayBhatia avatar Aug 15 '22 16:08 sunjayBhatia