contour icon indicating copy to clipboard operation
contour copied to clipboard

internal/provisioner: Unify the ensure objects created

Open izturn opened this issue 3 years ago • 5 comments

There are so many EnsureX in the sub-packages of objects, so unify them to EnsureObject to let maintain work easy

Signed-off-by: Gang Liu [email protected]

izturn avatar Aug 05 '22 10:08 izturn

Codecov Report

Merging #4659 (1497142) into main (c99fef5) will increase coverage by 0.21%. The diff coverage is 55.07%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4659      +/-   ##
==========================================
+ Coverage   75.69%   75.91%   +0.21%     
==========================================
  Files         140      140              
  Lines       16842    16750      -92     
==========================================
- Hits        12748    12715      -33     
+ Misses       3840     3783      -57     
+ Partials      254      252       -2     
Impacted Files Coverage Δ
internal/provisioner/objects/rbac/rbac.go 13.33% <0.00%> (ø)
...ernal/provisioner/objects/deployment/deployment.go 91.07% <35.71%> (+2.93%) :arrow_up:
internal/provisioner/objects/service/service.go 77.72% <37.50%> (+2.10%) :arrow_up:
internal/provisioner/objects/object.go 71.05% <43.75%> (-20.26%) :arrow_down:
...ovisioner/objects/rbac/clusterrole/cluster_role.go 80.59% <50.00%> (+8.80%) :arrow_up:
...ovisioner/objects/rbac/rolebinding/role_binding.go 74.50% <50.00%> (+7.84%) :arrow_up:
...nternal/provisioner/objects/dataplane/dataplane.go 87.41% <53.84%> (+1.76%) :arrow_up:
internal/provisioner/objects/rbac/role/role.go 73.58% <55.55%> (+6.42%) :arrow_up:
...ner/objects/rbac/serviceaccount/service_account.go 64.10% <57.14%> (+6.41%) :arrow_up:
...ts/rbac/clusterrolebinding/cluster_role_binding.go 74.50% <71.42%> (+9.50%) :arrow_up:
... and 8 more

codecov[bot] avatar Aug 05 '22 10:08 codecov[bot]

Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 30 days.

github-actions[bot] avatar Aug 20 '22 00:08 github-actions[bot]

ping @sunjayBhatia

izturn avatar Sep 05 '22 03:09 izturn

can remove the changelog, since this is not a user-facing change

sunjayBhatia avatar Sep 08 '22 14:09 sunjayBhatia

@sunjayBhatia PTAL

izturn avatar Sep 09 '22 01:09 izturn

Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 30 days.

github-actions[bot] avatar Sep 24 '22 00:09 github-actions[bot]