contour icon indicating copy to clipboard operation
contour copied to clipboard

Ability to specify custom error page

Open sgringwe opened this issue 6 years ago • 11 comments

It'd be nice to have a way to show a custom error message if an error happens at the contour level, such as no healthy upstream servers.

If there is already a way to do this, it'd be nice to document it.

Blocked:

  • [ ] https://github.com/envoyproxy/envoy/issues/1178

sgringwe avatar Apr 16 '18 15:04 sgringwe

This sounds like a good thing to have if someone wants to investigate the options inside Envoy for doing this.

davecheney avatar Apr 17 '18 08:04 davecheney

Looks like Envoy will support custom error responses in 1.9.0: https://github.com/envoyproxy/envoy/issues/1178.

dobozysaurus avatar Nov 29 '18 14:11 dobozysaurus

This is something i’d like to see fo contour 1.0. Marking as 0.15 to review if the feature has landed upstream.

davecheney avatar Jun 18 '19 08:06 davecheney

This feature right now is scheduled for Envoy v1.12.0.

stevesloka avatar Jul 18 '19 03:07 stevesloka

Thanks for checking. I'm moving this to the unplanned milestone. It's unlikely that we'll make it to envoy 1.12 by october for contour 1.0 so we'll reassess after contour 1.0 ships.

davecheney avatar Jul 18 '19 10:07 davecheney

xref #2515 which is closely related

jpeach avatar Jun 10 '20 00:06 jpeach

This will help i think https://github.com/envoyproxy/envoy/pull/11007

anupriya17 avatar Aug 09 '20 10:08 anupriya17

Yup, that looks promising.

xref #1898

jpeach avatar Aug 09 '20 22:08 jpeach

@jpeach @stevesloka @sgringwe I think we can close this one right ?

OrlinVasilev avatar Apr 12 '22 12:04 OrlinVasilev

@OrlinVasilev nope, you'd need a way to configure this in Contour now. =) It's great envoy has support now, so please leave open to add the Contour support.

stevesloka avatar Apr 12 '22 13:04 stevesloka

Great thanks!! @stevesloka

OrlinVasilev avatar Apr 12 '22 14:04 OrlinVasilev

Hi, just chiming in from what I think was creating a duplicate Issue. Essentially I'm looking for a way to handle a few cases:

  • When upstreams are unhealthy, rather than a static 503, I would like to customize the content. This is similar to how some cloud service providers handle things on eg "AWS Application Load Balancers".
  • When a wildcard parent route is specified, but the child router is not yet, or invalid, it would be nice to beable to "fall back" to a default handler.

In my days where I'd use the more common NGINX based ingresses, they used a feature called the default backend to accomplish some of these features.

oliverkane avatar Mar 22 '23 13:03 oliverkane