contour icon indicating copy to clipboard operation
contour copied to clipboard

internal/metrics: Contour should track Ingress metrics

Open youngnick opened this issue 5 years ago • 3 comments

Contour currently makes metrics available for each of HTTPProxy and IngressRoute (although it's deprecated). It should do the same for Ingress.

The current counters are for the CRDs are:

  • Total
  • Orphaned
  • Valid
  • Invalid
  • Root

I suggest for Ingress:

  • Total
  • Valid
  • Invalid

Although I'm unsure if we collect the validity information for Ingress currently.

youngnick avatar Mar 02 '20 03:03 youngnick

Status for Ingress is blocked currently on: https://github.com/projectcontour/contour/issues/403

Does Contour need to expose this info or it is already available from the k8s api? The understanding of valid vs invalid might be the reason to have it in Contour. Also, I guess you'd be able to understand what Contour is processing (i.e. ingress class, etc).

stevesloka avatar Mar 02 '20 18:03 stevesloka

For ingress, contour can track validity internally and emit metrics based on that.

jpeach avatar Mar 02 '20 23:03 jpeach

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Feb 28 '24 00:02 github-actions[bot]

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Mar 29 '24 00:03 github-actions[bot]