contour
contour copied to clipboard
Makefile: Misspell check missing docs directory
The check for spelling errors is missing the site/docs directories and aren't being checked for errors.
@stevesloka Is this done?
No, the spelling doesn't check things correctly. If you open a doc in the site, for instance, misspell something, it won't find it. In the tests I did, the tool didn't find errors when it should have.
I looked at this a bit and I think the problem is that misspell isn't a spell checker, it just corrects common misspellings. If the misspelling isn't already known to it, it won't do anything.
Unless we want to pull in a complete spell checker (e.g. envoy uses aspell with 800 lines of python to handle special cases), I'm inclined to close this out.
The Contour project currently lacks enough contributors to adequately respond to all Issues.
This bot triages Issues according to the following rules:
- After 60d of inactivity, lifecycle/stale is applied
- After 30d of inactivity since lifecycle/stale was applied, the Issue is closed
You can:
- Mark this Issue as fresh by commenting
- Close this Issue
- Offer to help out with triage
Please send feedback to the #contour channel in the Kubernetes Slack
The Contour project currently lacks enough contributors to adequately respond to all Issues.
This bot triages Issues according to the following rules:
- After 60d of inactivity, lifecycle/stale is applied
- After 30d of inactivity since lifecycle/stale was applied, the Issue is closed
You can:
- Mark this Issue as fresh by commenting
- Close this Issue
- Offer to help out with triage
Please send feedback to the #contour channel in the Kubernetes Slack