contour icon indicating copy to clipboard operation
contour copied to clipboard

Makefile: Misspell check missing docs directory

Open stevesloka opened this issue 5 years ago • 4 comments
trafficstars

The check for spelling errors is missing the site/docs directories and aren't being checked for errors.

stevesloka avatar Jan 17 '20 21:01 stevesloka

@stevesloka Is this done?

jpeach avatar Jan 30 '20 02:01 jpeach

No, the spelling doesn't check things correctly. If you open a doc in the site, for instance, misspell something, it won't find it. In the tests I did, the tool didn't find errors when it should have.

stevesloka avatar Jan 30 '20 02:01 stevesloka

I looked at this a bit and I think the problem is that misspell isn't a spell checker, it just corrects common misspellings. If the misspelling isn't already known to it, it won't do anything.

Unless we want to pull in a complete spell checker (e.g. envoy uses aspell with 800 lines of python to handle special cases), I'm inclined to close this out.

jpeach avatar Apr 15 '20 04:04 jpeach

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Apr 07 '24 00:04 github-actions[bot]

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar May 10 '24 00:05 github-actions[bot]