contour icon indicating copy to clipboard operation
contour copied to clipboard

Route Name feature

Open drao9 opened this issue 5 years ago • 3 comments

Recently, I worked on a feature to add route name in envoy's http route.Route structure. Here is the link for this issue: https://github.com/envoyproxy/envoy/issues/6364 I was wondering if the community would be interested in having route name field in ingressroute as a part of the route struct to support the feature in envoy. I can make the necessary changes for this.

drao9 avatar May 23 '19 22:05 drao9

Thank you for raising this issue. If I understand the linked feature request correctly this is for reporting stats. If Envoy grows this feature I think we could enable it in contour in the same way we name clusters currently; a predictable, but not configurable, value.

On 24 May 2019, at 08:39, Divyani Rao [email protected] wrote:

Recently, I worked on a feature to add route name in envoy's http route.Route structure. Here is the link for this issue: envoyproxy/envoy#6364 I was wondering if the community would be interested in having route name field in ingressroute as a part of the route struct to support the feature in envoy. I can make the necessary changes for this.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

davecheney avatar May 24 '19 01:05 davecheney

Yes, the envoy community is considering having stats per-route with the help of route name. Thanks!

drao9 avatar May 24 '19 18:05 drao9

Moving to the unplanned release as it is not clean when this feature will be delivered upstream.

davecheney avatar Jun 18 '19 09:06 davecheney