projectchrono
Missing CH_ROS_API for some header files
Hi Project Chrono,
Was trying to compile the chrono_ros module and realised that some of the header files (which is not header-only) such as ChROSBodyHandler.h is missing the CH_ROS_API, which results in linker issues and the build to fail.
Would you like me to make a PR to fix this or will you amend this on your end?
Thanks for the great work!
Yes, that would be very helpful and thank you.
Dan
Bernard A. and Frances M. Weideman Professor NVIDIA CUDA Fellow Department of Mechanical Engineering Department of Computer Science University of Wisconsin - Madison 4150ME, 1513 University Avenue Madison, WI 53706-1572 608 772 0914 http://sbel.wisc.edu/ http://projectchrono.org/
From: Lam Teng Foong @.> Sent: Saturday, January 4, 2025 8:30 AM To: projectchrono/chrono @.> Cc: Subscribed @.***> Subject: [projectchrono/chrono] Missing CH_ROS_API for some header files (Issue #539)
Hi Project Chrono,
Was trying to compile the chrono_ros module and realised that some of the header files (which is not header-only) such as ChROSBodyHandler.h is missing the CH_ROS_API, which results in linker issues and the build to fail.
Would you like me to make a PR to fix this or will you amend this on your end?
Thanks for the great work!
— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/projectchrono/chrono/issues/539__;!!Mak6IKo!NoKlTP7fY00YxKz72TII8JpvoqkiQk4ds7y9s-BhkiyoLSkoovMsNkH8JlEd0_5KFaAVNIiBtl6vpWKxIDWJsEs$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ABKUN4ZVXWPQQ5W24PNBKPD2I7V5HAVCNFSM6AAAAABUTE3OROVHI2DSMVQWIX3LMV43ASLTON2WKOZSG43DQOBWG43TKMA__;!!Mak6IKo!NoKlTP7fY00YxKz72TII8JpvoqkiQk4ds7y9s-BhkiyoLSkoovMsNkH8JlEd0_5KFaAVNIiBtl6vpWKxLnwSJxw$. You are receiving this because you are subscribed to this thread.Message ID: @.@.>>
Hi! Just saw this, pushed a fix to the feature/ros branch (which I plan to merge into main shortly).
Also, are you using Chrono::ROS on Windows? We don't actually build the ROS module on our windows CI, so if you are, I can look into adding this to one of our test cases.
@AaronYoung5 nice!
Sorry I did not have the time to make the PR myself.
Yes I observed this when building on Windows only.
I leave it up to your team to decide whether it is worth to have a CI pipeline for Windows+ROS2 build because I think it is not a very common setup.
You can close this issue after your branch is merged.
Thanks a lot for fixing!