calico icon indicating copy to clipboard operation
calico copied to clipboard

Migrate to ginkgo/v2

Open hjiawei opened this issue 1 year ago • 2 comments

Description

Related issues/PRs

Todos

  • [ ] Tests
  • [ ] Documentation
  • [ ] Release note

Release Note

TBD

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

hjiawei avatar Dec 14 '23 04:12 hjiawei

I looked into this some time ago and the show stopper was that v2 could not split the test into batches. That feature was removed and the author was in strong opposition to bringit back. It still could run multiple batches concurrently on a single machine, but not across multiple machines as we do. Is that issue fixed?

tomastigera avatar Dec 28 '23 16:12 tomastigera

I looked into this some time ago and the show stopper was that v2 could not split the test into batches. That feature was removed and the author was in strong opposition to bringit back. It still could run multiple batches concurrently on a single machine, but not across multiple machines as we do. Is that issue fixed?

Probably not. I am aware of your original post from the vendor issue tracker. It is still open at the moment. This is experimental for me to find out how far we can go with ginkgo v2.

hjiawei avatar Dec 28 '23 17:12 hjiawei

Is this still live, or should it be closed?

lwr20 avatar Jun 18 '24 16:06 lwr20